-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyarrow: Constrain pandas<3 if pyarrow<15 #727
base: main
Are you sure you want to change the base?
pyarrow: Constrain pandas<3 if pyarrow<15 #727
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Some questions:
|
I would personally prefer to not add this version constraint, but rather ensure pandas does not yet remove that API (I added a comment about that in pandas-dev/pandas#58467 (comment)). Of course that will still give you a warning when having this combination of pandas 3.0 with older pyarrow, which is maybe also something you want to avoid, but I would say that is then up to the user to decide if they want to ensure to use a more recent pyarrow version for that or not (the warning will also only be shown for specific cases, i.e. when having timezone aware timestamps) |
@jorisvandenbossche Ok, I understand, thank you for pointing me to this. In that case, I will hold off on this PR until a decision is made regarding which version of Pandas will remove the |
Marked as draft until then. Otherwise, this PR looks good. |
The missing context for was that pandas 3 is still unreleased as of May 19, 2024. As such, this can wait for a resolution upstream. |
Checklist
generate_patch_json.py
if absolutely necessary.pre-commit run -a
and ensured all files pass the linting checks.python show_diff.py
and posted the output as part of the PR.Pyarrow versions less than 15 result in an
AttributeError
when used with nightly builds of Pandas (>=3) due to breaking API changes in Pandas. Therefore, constrain the Pandas version to less than 3 if the Pyarrow version is less than 15.Truncated Diff
Full Diff (gist)