Patch notebook < 7 dependencies for jupyter_client and pyzmq #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @bollwyvl for some help with this PR! Thank you in advance! |
bollwyvl
reviewed
Aug 3, 2023
recipe/gen_patch_json.py
Outdated
| # all versions of Notebook < 7 should at least pin to | ||
| # jupyter_client < 8 and pyzmq < 25 as in | ||
| # https://github.com/jupyter/notebook/pull/6749 | ||
| if record_name == "notebook" and int(record["version"].split(".", 1)[0]) < 7: |
There was a problem hiding this comment.
Note the second checklist item in the PR template...
Make sure to add a condition
and record.get("timestamp", 0) < NOWso your changes only affect packages built in the past. Replace NOW withpython -c "import time; print(f'{time.time():.0f}000')"-->
...so perhaps something like:
if (
record_name == "notebook"
and int(record["version"].split(".", 1)[0]) < 7
and record.get("timestamp", 0) < 1691035398000
):There was a problem hiding this comment.
Thank you! I have updated the condition!
|
you can get the diff output from a known-good env on CI, a la: (view raw log, snip out the relevant bits)
Yeah, whatever it says on the tin, pretty much nothing from For conda-forge related stuff, i recommend:
# environment.yml
name: conda-forge-chores
channels:
- conda-forge
- nodefaults
dependencies:
- python >=3.11,<3.12
- mamba
- boa
- conda-smithy
- conda-build
- conda-lock
- grayskull
- conda-suggestdo all conda-forge-related stuff from this env, and keep it relatively up-to-date. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Thank you @bollwyvl for the guidance! I was able to follow your advice to run the script. The diff is quite long so please find it either in the dropdown below or this gist. Diff for patch |
|
I'm wondering if 1 year later this is still desired or if we can close it? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
python show_diff.pyand posted the output as part of the PR.Having trouble running this script due to issues with conda/conda_build. After installing the conda_build with
pipit pulled 2.1.5 and the following is the error message I am running into: