WIP/RFC: Add CUDA support for `aarch64`/`ppc64le` #2001

jakirkham · 2021-10-11T19:09:16Z

This includes aarch64 & ppc64le in the CUDA build matrices, which should allow packages that build on these other architectures to also support CUDA as well. Leverages existing CUDA migrations to add this content in.

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

Fixes #725

xref: conda-forge/cudatoolkit-feedstock#64

conda-forge-linter · 2021-10-11T19:09:21Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham · 2021-10-11T19:12:19Z

Would be great to get some feedback on this approach. Happy to adjust if there's a better way to do this 🙂

cc @isuruf @jaimergp @kkraus14 @leofang @Ethyling @raydouglass

recipe/migrations/cuda110.yaml

leofang · 2021-10-11T19:19:53Z

recipe/migrations/cuda110.yaml

      - quay.io/condaforge/linux-anvil-cuda:11.1    # [linux64 and os.environ.get("BUILD_PLATFORM") == "linux-64"]
+      - quay.io/condaforge/linux-anvil-ppc64le-cuda:11.1  # [linux and ppc64le and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]
+      - quay.io/condaforge/linux-anvil-aarch64-cuda:11.1  # [linux and aarch64 and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]
      - quay.io/condaforge/linux-anvil-cuda:11.2    # [linux64 and os.environ.get("BUILD_PLATFORM") == "linux-64"]
+      - quay.io/condaforge/linux-anvil-ppc64le-cuda:11.2  # [linux and ppc64le and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]
+      - quay.io/condaforge/linux-anvil-aarch64-cuda:11.2  # [linux and aarch64 and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]


John, could you remind me why we needed CUDA 11.1+ in this file? Don't we also have another migrator cuda111_112.yaml?

Think this was needed so we could add CentOS 7 support ( #1232 )

I think CUDA for aarch64 does not support CentOS 7
https://docs.nvidia.com/cuda/archive/11.0/cuda-installation-guide-linux/index.html

Yeah that's unrelated. Wouldn't worry about it 🙂

leofang · 2021-10-11T19:20:49Z

recipe/migrations/cuda110.yaml

-  - 7                   # [linux64]
-  - 8                   # [linux64]
+  - 7                   # [linux]
+  - 8                   # [linux]


Does this mean we need to build cuDNN for aarch64/ppc64le first before kicking off the migrator?

That's a good question. How have we handled cudnn before on new platforms? Would think that cudnn would be migrated before any package that depends on it, but it is always possible things get jammed up before it gets there

isuruf · 2021-10-12T00:38:18Z

Changing the migrators will not make the bot issue PRs.

jakirkham · 2021-10-12T01:04:09Z

Right and that's a question that I've been thinking about as well. Do we want to start a migration or do we want to just migrate a few packages based on need. There's probably a short list of things we would really want to see built out. After that it seems reasonable to leave it up to the feedstocks to make a decision. This might keep the CI load lower if that's a concern.

Though don't have strong feelings here. Am interested to hear other thoughts 🙂

jjacobelli · 2021-10-12T07:08:03Z

recipe/conda_build_config.yaml

+  - cos7   # [linux64 and ppc64le and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]
+  - cos7   # [linux64 and aarch64 and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]


I think this should be linux and ... instead of linux64 and ...

jjacobelli · 2021-10-12T07:09:43Z

recipe/conda_build_config.yaml

@@ -126,6 +128,8 @@ docker_image:                                   # [os.environ.get("BUILD_PLATFOR

  - quay.io/condaforge/linux-anvil-cuda:10.2       # [linux64 and os.environ.get("BUILD_PLATFORM") == "linux-64" and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos6"]
  - quay.io/condaforge/linux-anvil-cos7-cuda:10.2  # [linux64 and os.environ.get("BUILD_PLATFORM") == "linux-64" and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]
+  - quay.io/condaforge/linux-anvil-ppc64le-cuda:10.2  # [linux and ppc64le and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]
+  - quay.io/condaforge/linux-anvil-aarch64-cuda:10.2  # [linux and aarch64 and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]


We do not support CUDA 10.2 for aarch64. Should we use quay.io/condaforge/linux-anvil-aarch64-cuda:11.0 instead?

Yeah this is trickier than it seems as all the other architectures are using CUDA 10.2. So we would need to drop CUDA 10.2 in order to change to CUDA 11.0. Should add I'm ok with doing that and have checked with others to make sure it won't be too disruptive, but there are some other challenges. Basically we would want to get PR ( #1708 ) in, which has some blockers atm that have been difficult to address around aligning compiler versions

jjacobelli · 2021-10-12T07:10:25Z

recipe/migrations/cuda110.yaml

@@ -31,14 +31,22 @@ __migrator:
      - quay.io/condaforge/linux-anvil-cos7-cuda:10.1    # [linux64 and os.environ.get("BUILD_PLATFORM") == "linux-64"]
      - quay.io/condaforge/linux-anvil-cuda:10.2    # [linux64 and os.environ.get("BUILD_PLATFORM") == "linux-64"]
      - quay.io/condaforge/linux-anvil-cos7-cuda:10.2    # [linux64 and os.environ.get("BUILD_PLATFORM") == "linux-64"]
+      - quay.io/condaforge/linux-anvil-ppc64le-cuda:10.2  # [linux and ppc64le and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]
+      - quay.io/condaforge/linux-anvil-aarch64-cuda:10.2  # [linux and aarch64 and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]


We do not support CUDA 10.2 for aarch64

Ah right. Was look at ppc64le

Yeah starting with 11.0 makes sense. Maybe we can just do that with both. Thoughts @jaimergp?

We've been thinking about dropping the CUDA versions pre-11.0 anyway ( #1708 )

Yep, totally fine.

jjacobelli · 2021-10-12T07:15:35Z

recipe/migrations/cuda110.yaml

      - quay.io/condaforge/linux-anvil-cuda:11.1    # [linux64 and os.environ.get("BUILD_PLATFORM") == "linux-64"]
+      - quay.io/condaforge/linux-anvil-ppc64le-cuda:11.1  # [linux and ppc64le and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]
+      - quay.io/condaforge/linux-anvil-aarch64-cuda:11.1  # [linux and aarch64 and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]
      - quay.io/condaforge/linux-anvil-cuda:11.2    # [linux64 and os.environ.get("BUILD_PLATFORM") == "linux-64"]
+      - quay.io/condaforge/linux-anvil-ppc64le-cuda:11.2  # [linux and ppc64le and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]
+      - quay.io/condaforge/linux-anvil-aarch64-cuda:11.2  # [linux and aarch64 and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]


I think CUDA for aarch64 does not support CentOS 7
https://docs.nvidia.com/cuda/archive/11.0/cuda-installation-guide-linux/index.html

jjacobelli · 2021-10-12T07:16:41Z

recipe/migrations/cuda110.yaml

-  - 10.2                       # [linux64]
-  - 11.0                       # [linux64]
+  - 10.2                       # [linux]
+  - 11.0                       # [linux]


We do not support CUDA 10.2 for aarch64

jjacobelli · 2021-10-12T07:17:40Z

recipe/migrations/cuda110.yaml

@@ -72,10 +81,14 @@ docker_image:                                   # [os.environ.get("BUILD_PLATFOR

  - quay.io/condaforge/linux-anvil-cuda:10.2        # [linux64 and os.environ.get("BUILD_PLATFORM") == "linux-64" and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos6"]
  - quay.io/condaforge/linux-anvil-cos7-cuda:10.2   # [linux64 and os.environ.get("BUILD_PLATFORM") == "linux-64" and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]
+  - quay.io/condaforge/linux-anvil-ppc64le-cuda:10.2  # [linux and ppc64le and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]
+  - quay.io/condaforge/linux-anvil-aarch64-cuda:10.2  # [linux and aarch64 and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]


h-vetinari · 2022-02-28T05:13:22Z

Just FYI, it seems that a separate PR for PPC is progressing independently from this PR #2527.

leofang · 2022-02-28T05:45:49Z

Just FYI, it seems that a separate PR for PPC is progressing independently from this PR #2527.

I am so confused... It seems things are treated in different ways between this and that PR...

isuruf · 2022-03-07T22:03:14Z

As I said in #2001 (comment), this PR is wrong

jakirkham · 2022-03-22T20:16:35Z

Superseded by PR ( #2527 )

leofang reviewed Oct 11, 2021

View reviewed changes

Add CUDA support for aarch64/ppc64le

94628f1

jakirkham force-pushed the add_cuda_arch branch from a5565d9 to 94628f1 Compare October 11, 2021 21:43

jjacobelli reviewed Oct 12, 2021

View reviewed changes

jakirkham requested review from jaimergp and kkraus14 October 12, 2021 17:56

kkraus14 removed their request for review October 12, 2021 18:32

jakirkham mentioned this pull request Oct 14, 2021

Tracking updates for CUDA 11.3 and 11.4 conda-forge/cudatoolkit-feedstock#58

Closed

5 tasks

jakirkham mentioned this pull request Dec 1, 2021

Support CUDA 11.x on ppc64le conda-forge/nvcc-feedstock#75

Merged

5 tasks

jaimergp mentioned this pull request Dec 13, 2021

Build 7.7 release candidate conda-forge/openmm-feedstock#65

Merged

5 tasks

leofang mentioned this pull request Jan 31, 2022

CUDA for ppc64le / aarch64 conda-forge/cudatoolkit-feedstock#64

Closed

leofang mentioned this pull request Mar 7, 2022

Added ppc64le arch migrator for different cuda versions #2527

Merged

5 tasks

jakirkham closed this Mar 22, 2022

jakirkham deleted the add_cuda_arch branch March 22, 2022 20:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP/RFC: Add CUDA support for `aarch64`/`ppc64le` #2001

WIP/RFC: Add CUDA support for `aarch64`/`ppc64le` #2001

jakirkham commented Oct 11, 2021 •

edited

Loading

conda-forge-linter commented Oct 11, 2021

jakirkham commented Oct 11, 2021

leofang Oct 11, 2021

jakirkham Oct 12, 2021

jjacobelli Oct 12, 2021

jakirkham Oct 12, 2021

leofang Oct 11, 2021

jakirkham Oct 12, 2021

isuruf commented Oct 12, 2021

jakirkham commented Oct 12, 2021

jjacobelli Oct 12, 2021

jjacobelli Oct 12, 2021

jakirkham Oct 15, 2021

jjacobelli Oct 12, 2021

jakirkham Oct 12, 2021

jaimergp Oct 13, 2021

jjacobelli Oct 12, 2021

jjacobelli Oct 12, 2021

jjacobelli Oct 12, 2021

h-vetinari commented Feb 28, 2022

leofang commented Feb 28, 2022

isuruf commented Mar 7, 2022

jakirkham commented Mar 22, 2022

		- cos7 # [linux64 and ppc64le and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]
		- cos7 # [linux64 and aarch64 and os.environ.get("DEFAULT_LINUX_VERSION", "cos6") == "cos7"]

WIP/RFC: Add CUDA support for aarch64/ppc64le #2001

WIP/RFC: Add CUDA support for aarch64/ppc64le #2001

Conversation

jakirkham commented Oct 11, 2021 • edited Loading

conda-forge-linter commented Oct 11, 2021

jakirkham commented Oct 11, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

isuruf commented Oct 12, 2021

jakirkham commented Oct 12, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

h-vetinari commented Feb 28, 2022

leofang commented Feb 28, 2022

isuruf commented Mar 7, 2022

jakirkham commented Mar 22, 2022

WIP/RFC: Add CUDA support for `aarch64`/`ppc64le` #2001

WIP/RFC: Add CUDA support for `aarch64`/`ppc64le` #2001

jakirkham commented Oct 11, 2021 •

edited

Loading