Fix path on windows #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
So the osx failures are due to conda-forge/boa-feedstock#75 |
h-vetinari
requested review from
SylvainCorlay,
inducer,
isuruf and
jakirkham
as code owners
h-vetinari
force-pushed
the
rc
branch
4 times, most recently
from
e1afdc7 to
d1062ee
Compare
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
h-vetinari
force-pushed
the
rc
branch
2 times, most recently
from
d5e8167 to
965b6bc
Compare
file-selection for compiler-rt_win-64 was not broken (conda understands forward slashes), but intent is hopefully clearer now (no "Library\" on win).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figure out a stray suffix on the expected path to the windows builtins.Fix path for rc's also on windows; unix does this already for a long time:
compiler-rt-feedstock/recipe/build.sh
Lines 33 to 35 in 303aa87
Also pick up a pending cleanup now that conda/conda-build#4787 got fixed by the newest conda-build.Not ready yet, see conda-forge/boa-feedstock#75