Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use libcxx-devel #138

Closed
wants to merge 1 commit into from
Closed

use libcxx-devel #138

wants to merge 1 commit into from

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Aug 26, 2024

This goes together with conda-forge/libcxx-feedstock#183 (and backports; all for conda-forge/clangdev-feedstock#310), though the builds from that have been marked broken for now, because without this PR, our existing C++ compiler setup would break (as current clangxx_{{ target }} only pulls in libcxx which doesn't contain the headers anymore after the split).

For now, this PR is only for review (the changes are at least being tested for llvm_rc builds) and to discuss how to pull this off without too much breakage. Approach for now is to introduce libcxx-devel as a wrapper around the existing libcxx that keeps all of its content (for now), and once this PR is merged, we can actually enforce the split in libcxx properly.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

After discussion in conda-forge/clangdev-feedstock#310, this leaves the existing run-export

run_exports:
strong:
- libcxx >={{ libcxx_major }}

untouched. We'll add the static libs back to libcxx itself so that cross-compilation keeps working.

If you want me to leave a comment about potential improvements under conda/ceps#77, please let me know @isuruf. Otherwise this should be ready :)

@h-vetinari
Copy link
Member Author

Gentle ping @isuruf

@isuruf
Copy link
Member

isuruf commented Aug 29, 2024

This is not needed since clangxx now depend on libcxx-devel

@h-vetinari
Copy link
Member Author

Fair point. I guess we could just remove those dependencies outright here, as they're coming in through clangxx now.

@h-vetinari
Copy link
Member Author

OTOH, it still serves as a version anchor (so we shouldn't just delete it). OK, let's try leaving things as-is then.

@h-vetinari h-vetinari closed this Aug 29, 2024
@h-vetinari h-vetinari deleted the devel branch August 29, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants