Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libmlx* CDTs #33

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Aug 4, 2020

Includes libmlx4 and libmlx5 CDTs.

Please see the repo readme for directions on how to make PRs on this repo.

Checklist:

  • if you have added a CDT, it appears in the cdt_slugs.yaml file and
    you have rerun the script python gen_cdt_recipes.py.
  • if you have changed the CDT generator code (rpm.py), you have bumped
    the build number in conda_build_config.yaml and have remade all of the
    recipes via running python gen_cdt_recipes.py --force
  • if you have added a custom CDT recipe, you have added the name of the CDT
    with custom: true in the cdt_slugs.yaml file.
  • all CDT recipes have build number set by {{ cdt_build_number }} for
    old-style/legacy CDTs or {{ cdt_build_number|int + 1000 }} for new-style CDTs
  • if you see a warning about a CDT not having a license, you have added the
    license_file key in the cdt_slugs.yaml file with the path to the appropriate
    license in licenses/

NOTE: If you make any changes to cd_slugs.yaml, you need to reun the generator code
via python gen_cdt_recipes.py. Add the --fast option to make this go more quickly.

@jakirkham
Copy link
Member Author

This wound up touching and adding way more CDTs than I would have naively expected. Maybe I'm doing something wrong? 😬

@beckermr
Copy link
Member

beckermr commented Aug 4, 2020

Your machine is still not generating the CDTs properly. Can you send me the full output of the command you ran? Are there any errors?

@jakirkham
Copy link
Member Author

Yeah I'm not sure I understand why though (or how to fix it). My best guess is requirements might be missing ( #32 ), but I honestly don't know 🤷‍♂️ Happy to make changes 🙂

Just running python gen_cdt_recipes.py. Am using condaforge/linux-anvil-comp7 with the directory passed through (as this doesn't run on macOS).

There's a ton of output. Have attached as a text file.

@jakirkham
Copy link
Member Author

Installed the requirements noted here and reran. It seems to have done a bit better. Not sure if we are still missing things though. Please let me know 🙂

@beckermr
Copy link
Member

beckermr commented Aug 4, 2020

This will run on OS X. Install the requirements I sent.

I think I might have missed a key detail. Run the script over and over again until all of the warnings or errors go away. It very often hits a race condition.

@beckermr
Copy link
Member

beckermr commented Aug 4, 2020

Do you need these on cos7? As far as I can tell, there are no RPMs for them on cos7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants