Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set run_exports max_pin to x.x #12

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

jdblischak
Copy link
Member

@jdblischak jdblischak commented Jan 30, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Follow-up to conda-forge/azure-core-cpp-feedstock#11. Please approve/disapprove whether we should continue rolling out the max_pin="x.x" run exports to all the Azure SDK for C++ recipes

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we do this only to azure-core-cpp and azure-storage-common-cpp for now, which are lower-level packages.

@jdblischak
Copy link
Member Author

@teo-tsirpanis what about azure-identity-cpp?

@teo-tsirpanis
Copy link
Member

I consider it to be a high-level package because it provides some user-facing functionality. Users don't usually specifically want to install azure-core-cpp or azure-storage-common-cpp.

@jdblischak
Copy link
Member Author

Ok, I'm fine with this intermediate approach. We'll apply the stricter pins to azure-core-cpp and azure-storage-common-cpp for now and monitor how the next few releases go

@jdblischak jdblischak merged commit 1c92fb0 into conda-forge:main Jan 31, 2024
13 checks passed
@jdblischak jdblischak deleted the max-pin-x.x branch January 31, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants