Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark napari-0.4.15-0 as broken #433

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

jaimergp
Copy link
Member

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata pacthes to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Checklist:

  • Make sure your package is in the right spot (broken/* for adding the
    broken label, not_broken/* for removing the broken label, or token_reset/*
    for token resets)
  • Added a description of the problem with the package in the PR description.
  • Added links to any relevant issues/PRs in the PR description.
  • Pinged the team for the package for their input.

napari 0.4.15 was found to be incompatible with vispy 0.10, so a new build was added recently covering this detail in the requirements. While a repodata patch would have been more adequate (and that's how it'll be done in the future), right now there are two builds for 0.4.15, and build 0 still allows installation along vispy 0.10. Instead of adding the repodata patch now, which would result in two identical builds requirements-wise, I guess it's simpler to mark build 0 as broken?

ref: conda-forge/napari-feedstock#40 (comment)

@conda-forge/napari

@jaimergp jaimergp requested a review from a team as a code owner April 29, 2022 07:18
@ocefpaf ocefpaf merged commit 5504c34 into conda-forge:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants