-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub Info #6
Conversation
homepage was added in the same pull request and discussed in the same issue as the topics attribute |
We have added Travis and AppVeyor CI to this repo and an example test for the Thanks! |
I am going to update and test this one and then I will ping you, thanks |
Have a look at the discussion and the kind of testing we are talking about in #2, feedback is very welcome. |
@SSE4, please move this hook to the Thanks |
Signed-off-by: SSE4 <[email protected]>
Signed-off-by: SSE4 <[email protected]>
Signed-off-by: SSE4 <[email protected]>
Signed-off-by: SSE4 <[email protected]>
Signed-off-by: SSE4 <[email protected]>
Signed-off-by: SSE4 <[email protected]>
@jgsogo updated! |
Signed-off-by: SSE4 <[email protected]>
Although I'm not a great fan of env-variables I think that another one is needed to allow the user to restrict the version/branch that will modify the Github properties, as they are unique for all the repository. This env variable should be optional, and I'm not sure if it should be targetting the branch name or the recipe reference,... what do you think? |
unfortunately these properties aren't per branch, but per repository, so how to do in this case? |
If I have a Or I can have a Or maybe I should check if current branch is the default one in the remote repo (no need for an env variable). Maybe the option I like most is the last one... |
Signed-off-by: SSE4 <[email protected]>
Signed-off-by: SSE4 <[email protected]>
Signed-off-by: SSE4 <[email protected]>
@jgsogo this might be useful, but I have some doubts:
I suppose better and cleaner approach is to just check conan channel if it's |
@SSE4, is this comment related to this PR? |
@jgsogo yes, its about your suggestion for |
Ok, I forgot my previous comment, I was just checking the sources 😓 Yes, the suggestion about checking against a local repo is stupid, forget it... nevertheless, I would like to know more opinions about the second one (or something similar), two ways to implement it:
|
the last one is the most logical and simple for me (query GitHub default branch) |
Also, it doesn't require another env variable... and I really think it is useful to keep the information updated between the repo and the last version of the recipe. |
Signed-off-by: SSE4 <[email protected]>
@jgsogo I've added required check for the default branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start using it!
Skip CMAKE MODULES/PC-FILES for cmake recipe
similar to the Bintray Update plug-in
uses GitHub API https://developer.github.com/v3/
depends on:
homepage
attribute?