Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New attribute: topics #3671

Closed
1 of 3 tasks
uilianries opened this issue Oct 8, 2018 · 13 comments
Closed
1 of 3 tasks

New attribute: topics #3671

uilianries opened this issue Oct 8, 2018 · 13 comments
Assignees
Milestone

Comments

@uilianries
Copy link
Member

Hi!

Bincrafters have adopted the custom attribute homepage, which describes the author's URL. But thinking about the future, this attribute could be extracted from the recipe to fill Bintray page.

Now thinking about a possible new attribute and the possibility of having it in the future (Conan 2.0). Bintray uses labels to describe multiple topics related to the project. Github there is the same feature but it uses the name topics.

It could be:

class HelloConan(conanfile):
    name = "hello"
    version = "0.1.0"
    labels = ["example", "hello-world", "first-program"]
    ...

I would like to discuss this idea to integrate our efforts on integrating Bintray, including possible new attributes for Conan.

  • I've read the CONTRIBUTING guide.
  • I've specified the Conan version, operating system version and any tool that can be relevant.
  • I've explained the steps to reproduce the error or the motivation/use case of the question/suggestion.
@memsharded memsharded added this to the 1.9 milestone Oct 8, 2018
@memsharded
Copy link
Member

Better call it tags, as in Bintray.

@uilianries
Copy link
Member Author

tags sounds good

@uilianries
Copy link
Member Author

Should I include homepage also?

We discussed a longtime ago about homepage and it could be re-used to fill Bintray.

Many of Bincrafters recipes are using homepage.

uilianries added a commit to uilianries/conan that referenced this issue Oct 9, 2018
- Support new attribute on Conafile: tags

Signed-off-by: Uilian Ries <[email protected]>
uilianries added a commit to uilianries/conan that referenced this issue Oct 9, 2018
- Validate both inspect and info commands using tags
  as attribute

Signed-off-by: Uilian Ries <[email protected]>
uilianries added a commit to uilianries/conan that referenced this issue Oct 9, 2018
- Fix attribute order to validate inspect command

Signed-off-by: Uilian Ries <[email protected]>
@danimtb
Copy link
Member

danimtb commented Oct 10, 2018

@uilianries could homepage be confusing having url already there? I dont care too much, lets vote

@uilianries
Copy link
Member Author

Could be confusing when you are creating a recipe on same project tree. But it's documented.

Also when you are creating a recipe for a remote project is totally relevant, because you could find where is the original project and that info could be used to fill both Bintray and Github pages.

@Croydon
Copy link
Contributor

Croydon commented Oct 13, 2018

@Aalmann
Copy link

Aalmann commented Oct 13, 2018

This feature could also be used for #3498 isn't it?

@Aalmann
Copy link

Aalmann commented Oct 13, 2018

Does it also work for Artifactory?

@Croydon
Copy link
Contributor

Croydon commented Oct 13, 2018

Does it also work for Artifactory?

This adds a new official attribute to conanfiles. In which way they are getting used is pretty much a follow up.

@Aalmann
Copy link

Aalmann commented Oct 13, 2018

Ok. Thought the information will be published to Bintray as artifact property.

@uilianries
Copy link
Member Author

The idea is getting Conan plugins to fill Artifactory and Bintray metadata.

@SSE4
Copy link
Contributor

SSE4 commented Oct 20, 2018

I support this idea, as GitHub and Bintray need this information as well, and we may use plug-ins to fill all information automatically from the recipe
however, name tags might be very confusing, as it might refer to Git tags (or SVN tags), that's why GitHub uses topics instead of tags - exactly to avoid this confusion

@uilianries
Copy link
Member Author

topics sounds great too

uilianries added a commit to uilianries/conan that referenced this issue Oct 22, 2018
- Support new attribute on Conafile: tags

Signed-off-by: Uilian Ries <[email protected]>
uilianries added a commit to uilianries/conan that referenced this issue Oct 22, 2018
- Validate both inspect and info commands using tags
  as attribute

Signed-off-by: Uilian Ries <[email protected]>
uilianries added a commit to uilianries/conan that referenced this issue Oct 22, 2018
- Fix attribute order to validate inspect command

Signed-off-by: Uilian Ries <[email protected]>
uilianries added a commit to uilianries/conan that referenced this issue Oct 22, 2018
- We believe that topics is a better name, because tags remember svn
  and git features.
- We voted also for labels but topics sounds better.
- Thanks to @SSE4 for 'topics'

Signed-off-by: Uilian Ries <[email protected]>
uilianries added a commit to uilianries/conan that referenced this issue Oct 22, 2018
- Homepage is optional but will be listed by info and inspect
  commands
- Update unit tests to validate homepage
- Update topics to be used as tuple

Signed-off-by: Uilian Ries <[email protected]>
uilianries added a commit to uilianries/conan that referenced this issue Oct 24, 2018
memsharded added a commit that referenced this issue Oct 24, 2018
@lasote lasote changed the title New attribute: labels New attribute: topics Oct 26, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
- Support new attribute on Conafile: tags

Signed-off-by: Uilian Ries <[email protected]>
grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
- Validate both inspect and info commands using tags
  as attribute

Signed-off-by: Uilian Ries <[email protected]>
grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
- Fix attribute order to validate inspect command

Signed-off-by: Uilian Ries <[email protected]>
grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
- We believe that topics is a better name, because tags remember svn
  and git features.
- We voted also for labels but topics sounds better.
- Thanks to @SSE4 for 'topics'

Signed-off-by: Uilian Ries <[email protected]>
grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
- Homepage is optional but will be listed by info and inspect
  commands
- Update unit tests to validate homepage
- Update topics to be used as tuple

Signed-off-by: Uilian Ries <[email protected]>
grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants