Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[art:build-info] feature: Add --add-cached-nodes flag to allow recollection of non-built packages #127

Merged
merged 3 commits into from
May 23, 2024

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented May 21, 2024

based on the work done at #78 but dropping the python requires related changes from #75

closes #78
closes #100
closes #124

@CLAassistant
Copy link

CLAassistant commented May 21, 2024

CLA assistant check
All committers have signed the CLA.

@danimtb danimtb force-pushed the feature/art_bi_non-built_nodes branch from 8a26b19 to 9287ba5 Compare May 21, 2024 15:41
@danwalshnitro
Copy link

Hi @danimtb, this looks great. Can you please merge in the main branch? I need 2902e60 to be able to test this.

@danimtb
Copy link
Member Author

danimtb commented May 21, 2024

@danwalshnitro ups, sorry for that. It's done now. Thanks for the quick response!

@danimtb
Copy link
Member Author

danimtb commented May 23, 2024

@danwalshnitro did you have the time to try the changes? 😄

@danwalshnitro
Copy link

@danimtb Yeah, this PR works perfectly for our use-case so I've closed my PR. Thanks!

@czoido czoido marked this pull request as ready for review May 23, 2024 09:15
@czoido czoido merged commit fc63f08 into main May 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Use art:build-info for consumer of conan packages
4 participants