qt/5.15.2 #1759

ericLemanissier · 2020-05-27T22:39:21Z

Specify library name and version: qt/5.15.2

this is a port of https://github.com/bincrafters/conan-qt/

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2020-05-27T23:14:38Z

Some configurations of 'qt/5.15.0' failed in build 1 (a20703a5fd2695390df5dfc7b723f2e0f4402e95):

Linux x86_64, Release, gcc 5, libstdc++ . Options: qt:shared-True
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as cpp_info.builddirs. Currently folders declared: [''] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H019)
  - [HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files:
  - [HOOK - conan-center.py] post_package(): ERROR: [DEFAULT PACKAGE LAYOUT (KB-H013)] Unknown folder 'doc' in the package (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H013)
  - [HOOK - conan-center.py] post_package(): ERROR: [DEFAULT PACKAGE LAYOUT (KB-H013)] Unknown folder 'plugins' in the package (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H013)
  - [HOOK - conan-center.py] post_package(): ERROR: [DEFAULT PACKAGE LAYOUT (KB-H013)] Unknown folder 'mkspecs' in the package (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H013)
- Log download
- Log error Download
- Profile
Access to all the logs

recipes/qt/all/conanfile.py

conan-center-bot · 2020-05-28T05:41:18Z

Some configurations of 'qt/5.15.0' failed in build 2 (6e78c115b89b17bf7b9eaeb07e64d18f3dda9da4):

Linux x86_64, Release, gcc 5, libstdc++ . Options: qt:shared-True
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as cpp_info.builddirs. Currently folders declared: [''] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H019)
  - [HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files:
  - [HOOK - conan-center.py] post_package(): ERROR: [DEFAULT PACKAGE LAYOUT (KB-H013)] Unknown folder 'doc' in the package (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H013)
  - [HOOK - conan-center.py] post_package(): ERROR: [DEFAULT PACKAGE LAYOUT (KB-H013)] Unknown folder 'plugins' in the package (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H013)
  - [HOOK - conan-center.py] post_package(): ERROR: [DEFAULT PACKAGE LAYOUT (KB-H013)] Unknown folder 'mkspecs' in the package (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H013)
- Log download
- Log error Download
- Profile
Access to all the logs

rweickelt · 2020-05-28T07:04:13Z

@ericLemanissier:

Regarding DEFAULT_PACKAGE_LAYOUT:

you can use the configure option -plugindir (almost all top-level folders are configurable)
the mkspecs folder is not configurable. Do you have an idea?
doc folder should not be included in the package

Regarding CMAKE FILE NOT IN BUILD FOLDERS: Would it be enough to add lib/cmake to cpp_info.builddirs or is it required to list all leaf folders explicitly?

conan-center-bot · 2020-05-28T11:16:31Z

Some configurations of 'qt/5.15.0' failed in build 3 (fa16fd056a933bd43ffe51664075fa62b2a9812e):

Linux x86_64, Release, gcc 5, libstdc++ . Options: qt:shared-True
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as cpp_info.builddirs. Currently folders declared: [''] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H019)
  - [HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files:
- Log download
- Log error Download
- Profile
Access to all the logs

conan-center-bot · 2020-05-28T14:31:32Z

Some configurations of 'qt/5.15.0' failed in build 4 (d9a8e89381ed6d5f7ba477f4bb4c74d9f32f4a5c):

Linux x86_64, Release, gcc 5, libstdc++ . Options: qt:shared-True
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as cpp_info.builddirs. Currently folders declared: [''] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H019)
  - [HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files:
- Log download
- Log error Download
- Profile
Access to all the logs

conan-center-bot · 2020-06-04T16:38:18Z

Some configurations of 'qt/5.15.0' failed in build 5 (773e22e721d234f47d7e67b2200727c3fe7997cc):

Linux x86_64, Release, gcc 5, libstdc++ . Options: qt:shared-True
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as cpp_info.builddirs. Currently folders declared: [''] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H019)
  - [HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files:
- Log download
- Log error Download
- Profile
Access to all the logs

conan-center-bot · 2020-06-04T16:43:56Z

Failure in build 6 (badf9f845e62cc1a5d8ec2f3b2b433e5091c2f28):
qt/5.15.0:

Error processing recipe: Linux x86_64, Release, gcc 5, libstdc++ . Options: qt:shared-True
Unexpected error happened:

ERROR: qt/5.15.0: Error in config_options() method, line 182
	raise self.ConanInvalidConfiguration('Linux is not yet supported')
	AttributeError: 'QtConan' object has no attribute 'ConanInvalidConfiguration'

conan-center-bot · 2020-06-04T19:06:59Z

Some configurations of 'qt/5.15.0' failed in build 7 (756e0d1a975fbe1658b19b1cad9c31706ff3c16f):

Macos x86_64, Debug, apple-clang 9.1, libc++ . Options: qt:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 14, MTd. Options: qt:shared-False
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package(): ERROR: [PDB FILES NOT ALLOWED (KB-H017)] The conan-center repository doesn't allow PDB files (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H017)
  - [HOOK - conan-center.py] post_package(): ERROR: [PDB FILES NOT ALLOWED (KB-H017)] Found files:
- Log download
- Log error Download
- Profile
Access to all the logs

conan-center-bot · 2020-06-04T20:38:52Z

Some configurations of 'qt/5.15.0' failed in build 8 (9aeaec5f6ea5bec59aa90348406660f183907cbf):

Macos x86_64, Debug, apple-clang 9.1, libc++ . Options: qt:shared-True
Access to all the logs

see QTBUG-76777

conan-center-bot · 2020-06-05T08:40:43Z

All green in build 9 (7fb2b46478248648ee396a7f0172a42c997e33d4)! 😊

qt/5.15.0: Generated 26 packages. All logs here

ericLemanissier · 2020-06-05T13:41:24Z

So it seems I could successfully move mkspecs, plugins etc to the bin folder using -archdatadir -datadir and -sysconfdir arguments.
Regarding cmake, I simply deleted all the files, because they would be flagged by https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#kb-h016-cmake-modules-config-files. we probably want to add qt to the exceptions to this rule, otherwise there is no way to consume this package from cmake.
I keep the draft status for this PR, because it cannot be built under linux until #1605 is merged, but the PR is otherwise open for reviews.

rweickelt · 2020-06-05T15:14:32Z

Regarding cmake, I simply deleted all the files, because they would be flagged by https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#kb-h016-cmake-modules-config-files. we probably want to add qt to the exceptions to this rule, otherwise there is no way to consume this package from cmake

It can be consumed just fine with Qbs. Joke aside, I thought that the rule is to add all folders containing .cmake files into cpp_info.builddirs. Does that not work here?

I keep the draft status for this PR, because it cannot be built under linux until #1605 is merged, but the PR is otherwise open for reviews.

👍

ericLemanissier · 2020-06-05T15:18:05Z

https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#kb-h016-cmake-modules-config-files says The binary package cannot contain module or config CMake files ("Find*.cmake", "Config.cmake", "-config.cmake"). and it is what the hook enforces: https://github.com/conan-io/hooks/blob/master/hooks/conan-center.py#L614-L625
The only way out is to be added to the exclusion list

recipes/qt/5.x.x/conanfile.py

conan-center-bot · 2021-01-27T10:02:29Z

An unexpected error happened and has been reported. Help is on its way! 🏇

danimtb · 2021-01-27T10:47:23Z

relaunched

conan-center-bot · 2021-01-27T11:38:45Z

All green in build 74 (0c10c0cf75e0547c134515b78999d799b407dc41)! 😊

qt/5.15.2: Generated 106 packages. All logs here

intelligide · 2021-01-27T13:42:54Z

recipes/qt/5.x.x/conanfile.py

+        if not self.options.shared:
+            args.insert(0, "-static")
+            if self.settings.compiler == "Visual Studio":
+                if self.settings.compiler.runtime == "MT" or self.settings.compiler.runtime == "MTd":


Suggested change

if self.settings.compiler.runtime == "MT" or self.settings.compiler.runtime == "MTd":

if str(self.settings.compiler.runtime) in ["MT", "MTd"]:

uilianries

Great Job! The most complex recipe that we have so far

intelligide · 2021-01-27T18:38:15Z

ericLemanissier · 2021-01-28T07:49:55Z

Many thanks to all reviewers, contributors, and also thanks to @osechet and @lucienboillod who did the early work on this recipe !

(for qt 6)

boussaffawalid · 2021-01-28T07:56:50Z

I tried to run conan install qt/5.15.2@ and I got the error

ERROR: qt/5.15.2: Error in configure() method, line 233
        config.read(os.path.join(self.recipe_folder, "qtmodules%s.conf" % self.version))
        AttributeError: 'QtConan' object has no attribute 'recipe_folder'

ericLemanissier · 2021-01-28T08:01:34Z

are you running conan < 1.28.0 ?

boussaffawalid · 2021-01-28T09:00:53Z

@ericLemanissier yes, I updated to latest conan version and now it works. Thanks!
Maybe as an improvement, add a check for the minimum required conan version.

ericLemanissier · 2021-01-28T09:20:48Z

Well, required_conan_version was implemented in conan 1.28.0 too, so adding required_conan_version = ">=1.28.0" does not make much sense (other than documentation)

ericLemanissier added 2 commits May 28, 2020 00:35

qt/5.15.0

bd4cd89

disable glib harfbuzz gui and widgets(on linux)

a20703a

conan-center-bot added the Failed label May 27, 2020

Croydon reviewed May 27, 2020

View reviewed changes

recipes/qt/all/conanfile.py Outdated Show resolved Hide resolved

Croydon reviewed May 27, 2020

View reviewed changes

recipes/qt/all/conanfile.py Outdated Show resolved Hide resolved

Croydon reviewed May 27, 2020

View reviewed changes

recipes/qt/all/conanfile.py Outdated Show resolved Hide resolved

fixup references of packages (not yet on CCI)

6e78c11

move stuff to bin subfolder

fa16fd0

rweickelt mentioned this pull request May 28, 2020

Add qbs/1.18.0 recipe #1716

Closed

remove useless cmake code

773e22e

ericLemanissier force-pushed the qt branch from d9a8e89 to 773e22e Compare June 4, 2020 15:59

disable linux until required packages are on CCI

756e0d1

ericLemanissier force-pushed the qt branch from badf9f8 to 756e0d1 Compare June 4, 2020 16:46

remove pdb files

9aeaec5

SpaceIm mentioned this pull request Jun 4, 2020

[request] qt/5.12 qt/5.15 #1833

Closed

disable old apple compilers

7fb2b46

see QTBUG-76777

conan-center-bot removed the Failed label Jun 5, 2020

prince-chrismc reviewed Jan 26, 2021

View reviewed changes

recipes/qt/5.x.x/conanfile.py Outdated Show resolved Hide resolved

ericLemanissier added 9 commits January 27, 2021 07:51

remove unused patch files

8fa7957

fixup tools.Version usage

4bd44ad

don't dlete settings.os.version on macos

e57d6fb

smarter patch application

210c954

add winrt on msvc 2019

463468d

fixup ConanInvalidConfiguration

87ff600

use get_safe

1c9259b

simplify remove_files_by_mask

b8ee11f

formatting

0c10c0c

ericLemanissier dismissed Croydon’s stale review via 0c10c0c January 27, 2021 08:01

conan-center-bot added the Unexpected Error label Jan 27, 2021

conan-center-bot removed the Unexpected Error label Jan 27, 2021

intelligide reviewed Jan 27, 2021

View reviewed changes

prince-chrismc approved these changes Jan 27, 2021

View reviewed changes

SSE4 approved these changes Jan 27, 2021

View reviewed changes

uilianries approved these changes Jan 27, 2021

View reviewed changes

conan-center-bot merged commit 322994b into conan-io:master Jan 27, 2021

ericLemanissier deleted the qt branch January 28, 2021 07:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qt/5.15.2 #1759

qt/5.15.2 #1759

ericLemanissier commented May 27, 2020 •

edited

Loading

conan-center-bot commented May 27, 2020

conan-center-bot commented May 28, 2020

rweickelt commented May 28, 2020

conan-center-bot commented May 28, 2020

conan-center-bot commented May 28, 2020

conan-center-bot commented Jun 4, 2020

conan-center-bot commented Jun 4, 2020

conan-center-bot commented Jun 4, 2020

conan-center-bot commented Jun 4, 2020

conan-center-bot commented Jun 5, 2020

ericLemanissier commented Jun 5, 2020

rweickelt commented Jun 5, 2020

ericLemanissier commented Jun 5, 2020

conan-center-bot commented Jan 27, 2021

danimtb commented Jan 27, 2021

conan-center-bot commented Jan 27, 2021

intelligide Jan 27, 2021

uilianries left a comment •

edited

Loading

intelligide commented Jan 27, 2021

ericLemanissier commented Jan 28, 2021

boussaffawalid commented Jan 28, 2021

ericLemanissier commented Jan 28, 2021

boussaffawalid commented Jan 28, 2021

ericLemanissier commented Jan 28, 2021

	if self.settings.compiler.runtime == "MT" or self.settings.compiler.runtime == "MTd":
	if str(self.settings.compiler.runtime) in ["MT", "MTd"]:

qt/5.15.2 #1759

qt/5.15.2 #1759

Conversation

ericLemanissier commented May 27, 2020 • edited Loading

conan-center-bot commented May 27, 2020

conan-center-bot commented May 28, 2020

rweickelt commented May 28, 2020

conan-center-bot commented May 28, 2020

conan-center-bot commented May 28, 2020

conan-center-bot commented Jun 4, 2020

conan-center-bot commented Jun 4, 2020

conan-center-bot commented Jun 4, 2020

conan-center-bot commented Jun 4, 2020

conan-center-bot commented Jun 5, 2020

ericLemanissier commented Jun 5, 2020

rweickelt commented Jun 5, 2020

ericLemanissier commented Jun 5, 2020

conan-center-bot commented Jan 27, 2021

danimtb commented Jan 27, 2021

conan-center-bot commented Jan 27, 2021

intelligide Jan 27, 2021

Choose a reason for hiding this comment

uilianries left a comment • edited Loading

Choose a reason for hiding this comment

intelligide commented Jan 27, 2021

ericLemanissier commented Jan 28, 2021

boussaffawalid commented Jan 28, 2021

ericLemanissier commented Jan 28, 2021

boussaffawalid commented Jan 28, 2021

ericLemanissier commented Jan 28, 2021

ericLemanissier commented May 27, 2020 •

edited

Loading

uilianries left a comment •

edited

Loading