[tinyspline/0.5.0]: Make tinyspline's JSON support optional #12924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tinyspline's parson (json lib) it's using the same function name as json-c which makes it impossible to use both libs (statically) in the same project.
SpaceIm
reviewed
Sep 13, 2022
SpaceIm
reviewed
Sep 13, 2022
bog-dan-ro
commented
Sep 13, 2022
| -#include "parson.h" /* serialization */ | ||
| + | ||
| +#ifndef NO_JSON | ||
| +# include "parson.c" /* serialization */ |
There was a problem hiding this comment.
@SpaceIm here, I'm including parson.c instead of parson.h therefore it's not needed anymore in CMakeLists.txt
There was a problem hiding this comment.
It's not very elegant and more work for future maintainers if we want to unvendor parson in another PR.
|
Thank you for your contribution, let's wait for the upstream review. Maybe the author asks something, before approving your patch. |
|
All green in build 1 ( |
|
OP was not in favor of this new features As interesting as this improvement is, we can not accept it |
|
NP :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tinyspline's parson (json lib) it's using the same function name as json-c which makes it impossible to use both libs (statically) in the same project.
Bug & patch upstreamed msteinbeck/tinyspline#215 msteinbeck/tinyspline#216
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!