Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#95: make textarea only vertically resizable #158

Merged
merged 3 commits into from
May 24, 2024

Conversation

KasperZutterman
Copy link
Contributor

@KasperZutterman KasperZutterman commented May 23, 2024

Closes #95

What

Make text areas only vertically resizable, to not break the layout.

Testing

Before:

before.mov

After:

after.mov

@rubensworks
Copy link
Member

Do things still work properly for narrow browser windows and screens (e.g. mobile)?

@KasperZutterman
Copy link
Contributor Author

KasperZutterman commented May 24, 2024

@rubensworks I've added some fixes for small screens:

  • content doesn't overflow screen
  • settings cog doesn't overlap with input field.

This is the current state for small screens:

Screen.Recording.2024-05-24.at.10.04.08.mov

Compared to before this PR:

Screen.Recording.2024-05-24.at.10.08.47.mov

@rubensworks rubensworks merged commit 4b007de into comunica:master May 24, 2024
6 checks passed
@rubensworks
Copy link
Member

Excellent, nice work @KasperZutterman!
Feel free to claim the bounty via https://opencollective.com/comunica-association !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing text area breaks vertical layout
2 participants