Update the workflow file to follow the example of the main Comunica repository #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surilindur
force-pushed
the
chore/workflow-updates
branch
2 times, most recently
from
7932eaa to
9a7dfb8
Compare
rubensworks
requested changes
Nov 29, 2024
rubensworks
reviewed
Dec 3, 2024
rubensworks
reviewed
Dec 3, 2024
| run: yarn install --frozen-lockfile --ignore-engines | ||
| - name: Build project | ||
| run: yarn run build | ||
| - name: Build project -- esModuleInterop true |
There was a problem hiding this comment.
Just like on base comunica, we need to keep this one as well.
There was a problem hiding this comment.
The tsconfig file of link traversal actually has the flag in it already, so this extra build step is not needed here. That is why I removed it.
There was a problem hiding this comment.
Hmm, right, that's because of a dep on one of the inrupt libs.
Now, I would still keep it, because I want to remove that flag from the config when possible.
So we need to keep this in the CI, otherwise we may forget re-adding it.
There was a problem hiding this comment.
Okay, it is back now, but in the tooling test step. That one felt like the correct place to add it.
surilindur
force-pushed
the
chore/workflow-updates
branch
from
dd90751 to
b219bd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress PR, so I will make it a draft. It is also based off #154 so the changelog might look strange.This is now based on the master branch, and does not depend on other branches, so I made it an actual PR. Any feedback would be welcome. 🙂 I was going to enable the system tests on all three platforms, but they were all failing, maybe due to the server getting overloaded or something, so I left them as they were.