Add link filters and their extraction from VoID descriptions #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial draft for a link filter implementation, as a link queue wrapper that discards links upon being popped. This way, each link is only processed a maximum of one time by the actor, which should help with scaling concerns when the number of filters increases.
There is also a link filter extractor, that creates filters for every
void:uriSpaceandvoid:sparqlEndpointif there is a correspondingvoid:sparqlEndpoint. This logic will need a little bit more work, since the URI space and SPARQL endpoint predicates are not always on the same subject (which the implementation assumes). But I am opening the PR as a draft just so I do not forget.