Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActorExtractLinksHeaders #130

Merged

Conversation

wdantuma
Copy link
Contributor

@wdantuma wdantuma commented Apr 1, 2024

ActorExtractLinksHeaders

ActorExtractLinksHeaders is a ActorExtractLinks actor which adds links in link headers matching a regex pattern, usable for also following Auxillary resource links like "describedby" and "acl"

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2024

CLA assistant check
All committers have signed the CLA.

@rubensworks
Copy link
Member

Thanks @wdantuma, this looks really useful! I'll have a look at it next week.

@rubensworks
Copy link
Member

@wdantuma I just had a look, and everything looks great to me!

The reason why the CI is still failing is because the new actor will have to be added as a dependency to engines/query-sparql-link-traversal and engines/query-sparql-link-traversal-solid: https://github.com/comunica/comunica-feature-link-traversal/blob/master/engines/query-sparql-link-traversal/package.json#L51
Could you look into adding it at those 2 locations?

@wdantuma
Copy link
Contributor Author

@rubensworks i have added the dependencies to the new actor, thanks for the review

@rubensworks rubensworks merged commit 66181c0 into comunica:master Apr 11, 2024
11 checks passed
@wdantuma wdantuma deleted the Feature/actor-extract-links-header branch April 11, 2024 11:45
@rubensworks
Copy link
Member

Thanks @wdantuma! Released as 0.4.0.

@RubenVerborgh
Copy link

Posterior note that we should thread carefully, as this changes query semantics wrt completeness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants