Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made mediator combine array handled rejected tests #128

Conversation

constraintAutomaton
Copy link
Member

@constraintAutomaton constraintAutomaton commented Mar 24, 2024

In the current state of affairs if one test of the mediator combines array fail than the engine crashed. In this PR we solved the issue by detecting which actor fail and not running their procedure.

@constraintAutomaton constraintAutomaton changed the title Made mediator combine array handled rejected test Made mediator combine array handled rejected tests Mar 24, 2024
@rubensworks
Copy link
Member

rubensworks commented Mar 25, 2024

The filterErrors flag exists for this exact reason. Does enabling this flag solve your problem?

@constraintAutomaton
Copy link
Member Author

The filterErrors flag exists for this exact reason. Does enabling this flag solve your problem?

Probably, it was not there on the version of Comunica I was working with. I'm gonna test it tomorrow.

@constraintAutomaton constraintAutomaton deleted the fix/mediator-combine-handling-fail-test branch June 5, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants