Remove unneeded Map.has check in hash joins

This slightly improves performance.
comunica · Sep 24, 2024 · 11456bd · 11456bd
1 parent bfaaf7f
commit 11456bd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/join/HashJoin.js b/join/HashJoin.js
@@ -106,9 +106,11 @@ class HashJoin extends AsyncIterator
         function addItem(item)
         {
             let hash = this.funHash(item);
-            if (!this.leftMap.has(hash))
-                this.leftMap.set(hash, []);
             let arr = this.leftMap.get(hash);
+            if (!arr) {
+                arr = [];
+                this.leftMap.set(hash, arr);
+            }
             arr.push(item);
         }
     }

diff --git a/join/SymmetricHashJoin.js b/join/SymmetricHashJoin.js
@@ -110,6 +110,10 @@ class SymmetricHashJoin extends AsyncIterator
                 if (!map.has(hash))
                     map.set(hash, []);
                 let arr = map.get(hash);
+                if (!arr) {
+                    arr = [];
+                    map.set(hash, arr);
+                }
                 arr.push(item);
             }