Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(RHS2007): Individually mask each target in WE_Dual #117

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

JorisVincent
Copy link
Contributor

@JorisVincent JorisVincent commented Dec 18, 2023

This stimulus has two separate White's illusions in the same image. Each illusion has one target collinear with a black bar, and one target collinear with a white bar. Thus, the stimulus also has 1 target_mask that indexes all pixels belonging to the targets.
Previously, both targets collinear with black were lumped together / given the same mask idx -- as were the targets in white. As a result, there was no (straightforward) way to compare just the targets in one illusion, without accessing the targets in the other illusion.
Now, each target has its own index value (1-4), and each target can thus be accessed independently.

@JorisVincent JorisVincent self-assigned this Dec 18, 2023
@JorisVincent JorisVincent added the bug Something isn't working label Dec 18, 2023
Previously, the targets in black were lumped together, as were the targets in white. Now, each target, in each of the two stimuli, has its own mask idx
Only mask of WE_dual changed
@LynnSchmittwilken LynnSchmittwilken merged commit 3cba67d into dev Jan 2, 2024
8 checks passed
@LynnSchmittwilken LynnSchmittwilken deleted the fix/RHS2007 branch January 2, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants