Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use slash commands #1

Merged
merged 13 commits into from
May 19, 2024
Merged

feat: Use slash commands #1

merged 13 commits into from
May 19, 2024

Conversation

phoenixpereira
Copy link
Member

@phoenixpereira phoenixpereira commented May 17, 2024

Description

Use slash commands, Poetry and Black.

Changes Made

  • Switch to slash commands over prefix
  • Switch to Poetry over pip
  • Use Black for formatting and add Github Action
  • Add hi command group

Related Issues

N/A

Additional Notes

N/A

@phoenixpereira phoenixpereira added enhancement New feature or request ci Continuous Integration labels May 17, 2024
@phoenixpereira phoenixpereira requested review from rayokamoto and jsun969 and removed request for rayokamoto and jsun969 May 17, 2024 06:40
Copy link
Contributor

@rayokamoto rayokamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to provide an example of a command group?

.example.env Outdated Show resolved Hide resolved
.github/workflows/lint.yml Outdated Show resolved Hide resolved
.github/workflows/lint.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@phoenixpereira phoenixpereira requested a review from rayokamoto May 17, 2024 13:33
@phoenixpereira phoenixpereira self-assigned this May 17, 2024
src/commands/hi.py Outdated Show resolved Hide resolved
@phoenixpereira phoenixpereira requested a review from rayokamoto May 19, 2024 02:17
Copy link
Contributor

@rayokamoto rayokamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change then good to merge

src/main.py Outdated
intents.message_content = True


class DuckBot(Client):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use commands.Bot rather than Client as the former provides more functionality

@phoenixpereira phoenixpereira requested a review from rayokamoto May 19, 2024 06:16
@rayokamoto rayokamoto merged commit 8c328d9 into main May 19, 2024
1 check passed
@rayokamoto rayokamoto deleted the slash-command branch May 19, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants