Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add createOfLast in MutArray module and update Array.createOfLast #2900

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Add createOfLast in MutArray module and update Array.createOfLast #2900

merged 1 commit into from
Dec 15, 2024

Conversation

adithyaov
Copy link
Member

No description provided.

@adithyaov adithyaov linked an issue Dec 11, 2024 that may be closed by this pull request
Add createLastOf in Data.MutArray #2050
Closed
@adithyaov adithyaov changed the title Multiple issue resolution Add createOfLast in MutArray module and update Array.createOfLast Dec 11, 2024
@harendra-kumar
Copy link
Member

There seems to be no significant change. But strangely the regression suite failed at createOfLast:


All 1 tests passed (0.77s)
All.Data.Array/o-n-space.elimination.createOfLast.Max +RTS -T -K1M -M32M -RTS
Running: dist-newstyle/build/x86_64-linux/ghc-9.2.7/streamly-benchmarks-0.0.0/b/Data.Array/build/Data.Array/Data.Array -j 1 +RTS -T -K1M -M32M -RTS --csv=charts/Data.Array/results.csv.tmp -p '$0 == "'"All.Data.Array/o-n-space.elimination.createOfLast.Max"'"'
All
  Data.Array/o-n-space
    elimination
Error: The operation was canceled.

@adithyaov adithyaov merged commit 68c8de2 into master Dec 15, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add createLastOf in Data.MutArray
2 participants
@adithyaov @harendra-kumar