PR to close simple commits #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1764,6 +1780,7 @@ case $1 in | |||
| cabal-new) die "cabal-new is not supported, please use cabal-v2 instead";; | |||
| cabal-v2) shift; eval_env "$@"; BUILD=cabal-v2;; | |||
| stack) shift; eval_env "$@"; BUILD=stack;; | |||
| hlint) shift; eval_env "$@"; BUILD=hlint;; | |||
There was a problem hiding this comment.
Did you check all places where "$BUILD" is being used? At many places if it is not cabal build we assume stack build in the else case, now that we have hlint build we should consider that case too.
There was a problem hiding this comment.
Yes, those cases don't occur because of the final if-else statement. Maybe we could set "$COMMAND" and derive "$BUILD" accordingly.
| fi | ||
| local sane_ignore_file=".packcheck/sane-ignore" | ||
| printf "$pi_files_exist" > "$sane_ignore_file" | ||
| cat "$sane_ignore_file" .packcheck/tar-ztf.txt \ |
There was a problem hiding this comment.
Do we need a sane_ignore_file? anyway the results will be correct even with the insane one.
harendra-kumar
approved these changes
Jul 14, 2021
Applicable for: - githubci - circleci - travisci
This was referenced Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes,
Partially closes,