Skip to content

Commit

Permalink
Add comments clarifying the sdist build code
Browse files Browse the repository at this point in the history
  • Loading branch information
harendra-kumar committed Jun 15, 2021
1 parent 35efa99 commit acc3d3e
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions packcheck.sh
Original file line number Diff line number Diff line change
Expand Up @@ -1295,6 +1295,7 @@ create_and_unpack_pkg_dist() {
# Unpack the tar inside .packcheck directory
mkdir -p .packcheck || exit 1

# XXX Move the git repo comparison code to a separate function
local gitcmd="$(which_cmd git)"
test -n "$gitcmd" || echo "WARNING! git command not found skipping source distribution comparison with git repo"

Expand Down Expand Up @@ -1367,6 +1368,11 @@ then add them to .packcheck.ignore file at the root of the git repository."
$OS_UNGZTAR_CMD $tarpath
echo

# NOTE: We are entering the sdist directory inside .packcheck now. The
# original tree is intact. When we remove the cabal.project or stack.yaml
# files here, it is removed from the sdist copy not from the original tree.
# However, the CABAL_PROJECT and STACK_YAML variables are pointing to a path
# relative to the original tree root.
cd ${1}
if test "$BUILD" = stack
then
Expand Down

0 comments on commit acc3d3e

Please sign in to comment.