Introduce named mappings to template substitution #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithDefaultWhenAbsence` and `withRequired` functions * By directly using `Substitute` function, `Config` cannot pass further, thus not preserved Signed-off-by: Vigilans <[email protected]>
* Named mapping is enabled only when `Config.namedMappings` is provided, otherwise compatibility is kept Signed-off-by: Vigilans <[email protected]>
Signed-off-by: Vigilans <[email protected]>
* Support formats like `${mapping[key]:-defaultValue}` `${mapping[key]:+presenceValue}`
* Support detecting presence of key in a named mapping through `${mapping[key]?errorMessage}`
Signed-off-by: Vigilans <[email protected]>
Signed-off-by: Vigilans <[email protected]>
* So named mappings can use panic to report error Signed-off-by: Vigilans <[email protected]>
Signed-off-by: Vigilans <[email protected]>
Signed-off-by: Vigilans <[email protected]>
Signed-off-by: Vigilans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for named mappings's syntax
${name[key]}intemplatepackage.Named Mappings
By
Mapping, we mean a user-supplied function to lookup value from key:type Mapping func(string) (string, bool). In compose it is provied with environment lookup.A named mappings is a collection of
Mapping, indexed by name key. It allows temporarily switching to other mappings other than default during interpolation.Template Syntax
Named mapping are used with syntax
${name[key]}, where an alternativeMappingis retrieved by keyname, and look it up using keykey.It supports all functions in default mappings:
${name[key]:-default},${name[key]:+presence},${name[key]?error}.It also supports mapping key to be a templated value, e.g.
${env[DIR_${compose[replica-index]}]}.