Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in model loading,
workingDir
refers to the relative directory to theworkingDir
of upper caller, instead of the process's current working directory. This makes operations likeos.Stat(filepath.Join(workingDir, f))
will fail if invoked on suchworkingDir
in nested include/extends.This PR fixes such calling in
ApplyInclude
's env file handling logic, to useoptions.ResourceLoaders
to retrieve the correct absolute path, instead of relying onfilepath.Join(workingDir, f)
.