define Options type for (driver) options we pass as-is to runtime #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r runtine Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
commented
Sep 28, 2023
| @@ -979,18 +982,18 @@ type IPAMPool struct { | |||
| Subnet string `yaml:"subnet,omitempty" json:"subnet,omitempty"` | |||
| Gateway string `yaml:"gateway,omitempty" json:"gateway,omitempty"` | |||
| IPRange string `yaml:"ip_range,omitempty" json:"ip_range,omitempty"` | |||
| AuxiliaryAddresses map[string]string `yaml:"aux_addresses,omitempty" json:"aux_addresses,omitempty"` | |||
There was a problem hiding this comment.
I wonder this one should be defined as a map[string]net.IPAddr and we rely on ParseIP for parsing and validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce
Optionsas an explicit type formap[string]stringdriver options we pass as-is to container runtime