-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic filter test for layout resource #150
Add basic filter test for layout resource #150
Conversation
Is this going in the right direction? I guess all i am missing now for the layout component are the different scenarios
|
This looks good thanks. |
Yes i can split it into 2 scenarios 👍 The docker config would be helpful for manual playing around but i think i can add the test cases mentioned above without. So no need to rush it. |
Sorry for the delay, I'll be working on the docker configs now, see what I can get going. |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Hi @bofalke - sorry I've been extremely tied up with Antoine and many mercure updates and other fixes which I'm continuing to work on today actually - I think I've just finished my last update to |
Sorry for the delay, i was a little busy the last weeks. However i think i finally managed to include all the tests for the layout component. The GitGuardian Security Check occured after i merged the main branch, i guess i will try and rebase it |
9f939fd
to
37d9f91
Compare
The gitguardian is OK, it's a dummy secret but looks real so I think I just need to make it look like a dummy :) |
These are very good tests thank you for your work on it. I'm happy to merge when you are finished and I can easily duplicate these tests for the page resource as well with these layout resource tests in place. |
Also lowest dependencies tests will fail for now until APIP core 3.0.3 is released. I didn't want the fixme statement in there and we will require that as the minimum dependency. |
Okay it is green now as i removed the merge commit by rebasing onto the main branch. However Scrutinizer fails during composer install, anything i need to do here? |
37d9f91
to
3a34540
Compare
Code Climate has analyzed commit 3a34540 and detected 0 issues on this pull request. View more on Code Climate. |
Nah that's all good, thanks - merging now. |
Cool thanks! I try to add some tests for the other components as well |
Amazing, thank you! |
Ref #113
First Test for the Layout Resource filter.