-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 67 - Add callback to return full axe-core results object #68
base: master
Are you sure you want to change the base?
Issue 67 - Add callback to return full axe-core results object #68
Conversation
gilgold
commented
Oct 13, 2020
- Adding a callback method for handling the full axe-core results object
- Adding a callback method for handling the full axe-core results object
- Updating README.md with resultsCallback info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the pull request!
This looks like a breaking change. I'm thinking about a new API for the next major release, and probably we'll need to replace all positional arguments of checkA11y
with an object because we already have way too many and they are all optional.
I'll keep this pull request as a reference, and either include in the new version or ask you to rebase it on top of it.
big plus 1 to using an object for the args. |
That's a good point! |
@sapegin - Hi, do you have any ETA for the new API to move to an arguments object? Do you need any help with this? |
I drafted my ideas on the new API: #75. I hope this covers your use case — let me know what you think. |