Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/event types #16

Merged
merged 23 commits into from
Feb 1, 2024
Merged

Refactor/event types #16

merged 23 commits into from
Feb 1, 2024

Conversation

mrkarimoff
Copy link
Contributor

@mrkarimoff mrkarimoff commented Jan 25, 2024 •
edited
Loading

This PR intends to make the following changes:

  • Adds optional metadata field to AnalyticsEventBase to allow both AnalyticsEvent and AnalyticsError to have metadata properties
  • Entends AnalyticsError from AnalyticsEventBase to have an optional metadata field and makes the error property the JavaScript Error
  • Inserts analytics error metadata into the Database
  • Adds Drizzle ORM integration for DB communication to the analytics website
  • Adds Filter for the event table on the analytics dashboard
  • Removes tabs and adds one more info box for DataExport on the dashboard

@vercel Vercel
Copy link

vercel bot commented Jan 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
error-analytics-microservice ✅ Ready (Inspect) Visit Preview ✅ 5 resolved Feb 1, 2024 8:28am

@mrkarimoff mrkarimoff marked this pull request as ready for review January 25, 2024 11:29
@mrkarimoff mrkarimoff requested a review from jthrilly January 25, 2024 11:30
jthrilly

This comment was marked as outdated.

Sign in to view

@mrkarimoff mrkarimoff requested a review from jthrilly January 29, 2024 16:18
@jthrilly
Update tsconfig.json - remove es6 so that app can inherit from es2020…
3940b29 
… in base.json

Drizzle issue here:drizzle-team/drizzle-orm#803    

Drizzle requires target newer than es5, but next was shipping es5 until recently (even though it didn't use it). 

Fix is to remove override in this config file and let it use the base.json target, which is es2020.
@jthrilly jthrilly merged commit ef62e4e into main Feb 1, 2024
4 checks passed
@jthrilly jthrilly mentioned this pull request Feb 1, 2024
Merged
@jthrilly jthrilly deleted the refactor/event-types branch March 27, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthrilly jthrilly jthrilly approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrkarimoff @jthrilly