Fix/multiple ego forms not submitting #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix appears to work fine for EgoForm, it also fixes 0 value validations in the RadioGroups. I'm not keen on the amount of indirection in the clickNext clickPrevious implementations, is there a way we could avoid the use of refs? I think since this fixes the existing implementation it should still be merged. |
I think this would fall under the remit of this existing refactor: https://github.com/codaco/Network-Canvas/issues/927 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #946. The issue was not with exporting, but rather with multiple consecutive ego forms. This ensures that consecutive ego forms aren't a problem, and fixes an issue with ego default values not populating correctly.
Also fixes #947. We had updated protocol validation to allow it, but had not updated field validation to accept
0as valid.