Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 6.0.0 #1071

Merged
merged 73 commits into from
Oct 19, 2020
Merged

Version 6.0.0 #1071

merged 73 commits into from
Oct 19, 2020

Conversation

jthrilly
Copy link
Member

@jthrilly jthrilly commented Aug 14, 2020

Obviously this PR is pretty substantial, and I don't expect that it can be reviewed in minute detail. Instead I would like you to focus on the core functionality, and to check that the essential functions of the application are working for you. We will deal with bugs in future PRs.

Changes:

  • Introduces substantially redesigned card-based start screen (Resolves Refactor start screen #1029) including sections for common actions. All sections should be sensitive to app state and device state, meaning that they will contextually show themselves when their action is possible, and will disable subsets of their actions according to device network state/server pairing state.
  • Adds a "preloading" animation that lets the app transition into the start screen view nicely on first launch.
  • Adds a "welcome section" that can be optionally shown/hidden (default is shown on first launch) containing links to documentation.
  • In preparation for stable, bumps the app version to 6.0.0 all app bundles and local storage keys to a new identifier.
  • Removes compatibility with schema versions prior to 4, since this will be the launch schema version.
  • A new useServerConnectionStatus hook has been written, which allows components to poll for heartbeat messages from server (not currently implemented).
  • The flow for pairing with Server and fetching protocols has been redesigned and largely re-written on the component level. Pairing takes places from a dedicated Server communication card, and fetching protocols happens from a dedicated protocol import/management card. Resolves ready to upload to server message incomplete #1067.
  • A toast UI system has been written and implemented for protocol import, protocol export, and server pairing success.
  • The display of protocol cards, session cards, and cards representing a computer running Server have been standardised within NC-UI and implemented here.
  • Refactors import and export behaviour to not use redux state, but instead to dispatch toast actions.
  • Redesigns the finish interview screen to remove delete session and export options. Includes a finishedAt session property, as well as in-session duration information.
  • Fixes incorrect windows file menu items.
  • Implements the ability to have custom validation functions passed to a field and through a form config object. These validation functions can contain custom reject messages.
  • Removes obsolete cruft related to react-router, and implements latest libraries. Fixes Update react-redux for hooks support #1055
  • Updates redux and redux-persist.
  • Changes the app frame on windows to show the menu bar, and changes the startup behaviour to windowed. Full screen option is still available, but ive seen too many people be confused by it.
  • Resolves sessions list filter error #1034
  • Resolves Drag and Drop Performance issues #1031 (and helps with Sociogram Performance degrades substantially as redux store gets larger #1066) by successfully throttling dispatch of actions that update node position while dragging
  • Changes drag manager portalling to the body element to help with z-index issues.
  • Removes the selectable behaaviour in favour of components binding their own events and managing props of children.
  • Implements a new filtered list wrapper for start screen items, and preserves the old one for use in the interview.
  • Implements an <ExternalLink /> component and an openExternalLink method to allow documentation links to be opened from within the app.
  • Removes the development protocol as a submodule. As far as I could tell it wasn't being used.

@jthrilly jthrilly marked this pull request as ready for review September 30, 2020 01:25
@jthrilly jthrilly changed the title Feature/better start screen 2 Version 6.0.0 Sep 30, 2020
@jthrilly
Copy link
Member Author

jthrilly commented Oct 1, 2020

  • Pressing "tab" while the toggle show welcome message switch is active makes the panel vanish!
  • What's new section visible (use system from architect), with update messaging moved to toast
  • Change box shadow to match architect: box-shadow: 0 unit(1) .2rem 0 var(--architect-panel-shadow);

Kate's feedback:

  • Don't show "compelete" toast when export was cancelled
  • Server protocol list warped:

image (1)

@rebeccamadsen
Copy link
Contributor

Looks pretty great! I can add one more observation. The date field does some funky things with aligning here, which isn't in master.

date

@jthrilly
Copy link
Member Author

Update:

  • I can't see anything wrong with the server protocol fetch dialog that would cause that wonky rendering, but I saw it a single time too. I've updated framer-motion, and I haven't seen it yet so we will just have to see if we can get a firm reproduction.
  • Date picker bug was resolved in UI
  • I'm going to leave the "complete" toast for now - I think its consistent with the pattern.
  • I can't fix the tab issue. Leaving it for now

@jthrilly
Copy link
Member Author

jthrilly commented Oct 16, 2020

Outstanding iOS issues:

  • Server discovery is broken
  • New case form doesn't let you type into it
  • Timeline navigation invisible
  • Ego form progress bar too close to bottom of the screen
  • Import from file doesn't trigger file chooser
  • Forms push content off screen (regression)
  • Header background gradient renders incorrectly

@jthrilly jthrilly merged commit 03e5503 into master Oct 19, 2020
@jthrilly jthrilly deleted the feature/better-start-screen-2 branch September 4, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants