-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 6.0.0 #1071
Merged
Merged
Version 6.0.0 #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m file to return a promise
Kate's feedback:
|
Update:
|
Outstanding iOS issues:
|
wwqrd
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviously this PR is pretty substantial, and I don't expect that it can be reviewed in minute detail. Instead I would like you to focus on the core functionality, and to check that the essential functions of the application are working for you. We will deal with bugs in future PRs.
Changes:
useServerConnectionStatus
hook has been written, which allows components to poll for heartbeat messages from server (not currently implemented).finishedAt
session property, as well as in-session duration information.selectable
behaaviour in favour of components binding their own events and managing props of children.<ExternalLink />
component and anopenExternalLink
method to allow documentation links to be opened from within the app.