Fix/hyperlist rendering #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
next.js generates compiler aliases so that references to legacy browser code in react-dom/server throw errors. however, renderToString is depreciated. this bypass allows for using it
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jthrilly
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HyperList component is a virtualized list of data cards. The height of these data cards is calculated dynamically by using the react-dom server API
renderToString.Next 14 throws an error for importing this, despite the fact that the API is depreciated in React. This is because NextJS generates compiler aliases so that references to legacy browser code in react-dom/server throw errors.
This PR implements a workaround for this issue by bypassing the alias and maintaining the existing implementation.