Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/interviewer scrolling #54

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Feature/interviewer scrolling #54

merged 6 commits into from
Jan 19, 2024

Conversation

buckhalt
Copy link
Member

This feature implements:

  • Fixed full height for the interview, accounting for the banner
  • Allowing scroll on Information Interfaces

@vercel Vercel
Copy link

vercel bot commented Jan 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fresco ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 2:48pm

@buckhalt buckhalt marked this pull request as ready for review January 18, 2024 22:58
@jthrilly jthrilly self-requested a review January 19, 2024 14:55
jthrilly
jthrilly approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@jthrilly jthrilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work great! Not reviewed the implementation in depth, but we can fix later.

@jthrilly jthrilly merged commit c67e372 into main Jan 19, 2024
3 checks passed
@jthrilly jthrilly deleted the feature/interviewer-scrolling branch April 5, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthrilly jthrilly jthrilly approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buckhalt @jthrilly