-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytics: update for v2.0.0 compatibility #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jthrilly
changed the title
update for v2.0.0 compatibility
Analytics: update for v2.0.0 compatibility
Jan 10, 2024
buckhalt
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Fresco to take advantage of the changes in complexdatacollective/network-canvas-monorepo#14
Specifically:
process.env
and replaces withenv
shim from t3-oss. Renames env variable toDISABLE_ANALYTICS
so that it defaults to false.Note: The above caused issues with the github actions implementation for testing building. Basically, because the new implementation invokes
getInstallationId
in the route handler, and because that function uses a database call, we were ending up with the action failing because the database wasn't available.Rather than add the database environment variable to the github actions environment, I instead created a new env variable,
INSTALLATION_ID
, which when present short circuits the database call. This is actually pretty useful, because it will enable us to filter out our dev environment events from the analytics. I added this variable to the vercel environment, as well as to my local environment.