Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Floating feedback button #39

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Conversation

mrkarimoff
Copy link
Contributor

@mrkarimoff mrkarimoff commented Dec 6, 2023

This PR introduces the Feedback Button feature, allowing users to provide feedback or report bugs through a ClickUp form.

The feature includes a floating button with a robot emoji, a tooltip with a helpful message, and a modal with an embedded ClickUp form for bug reporting.

The tooltip message disappears after 10 seconds and the robot emoji moves to the right corner of the screen.

Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fresco ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 1:15pm

Copy link
Member

@buckhalt buckhalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feature! Left a couple of ideas below.

<ClickUpFormModal open={open} setOpen={setOpen} />
<motion.div
initial={{ opacity: 1 }}
animate={{ x: '25px', rotate: -60 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion the rotated button here looks a bit odd. Is the idea just to move it out of the way after the tooltip disappears? I think it would be fine to animate it to the bottom corner without rotating.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks creepy, right? 😅 I'll fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put the feedback button in a top-level banner according to Joshua's suggestion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The top-level banner looks awesome!

components/FeedbackButton/ButtonTooltip.tsx Outdated Show resolved Hide resolved
Copy link
Member

@jthrilly jthrilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like how the form is looking inside of the modal window. The scrolling isn't a good user experience, and I don't like the duplication of the title.

Could you try putting it inside of a shadcn "sheet" instead?: https://ui.shadcn.com/docs/components/sheet

@mrkarimoff mrkarimoff merged commit 7b61cf4 into main Dec 12, 2023
3 checks passed
@jthrilly jthrilly deleted the feature/feedback-button branch April 16, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants