Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client side protocol validation #33

Merged
merged 15 commits into from
Nov 22, 2023

Conversation

jthrilly
Copy link
Member

@jthrilly jthrilly commented Nov 8, 2023

This PR implements client-side validation of protocols, and reworks the general protocol upload flow to use the best practices we've established since the first implementation.

  • Extract protocol.json client-side, allowing immediate validation feedback for the user, and eliminating the need to upload any data.
  • Implement client-side extraction of protocol assets, which can then be uploaded only when the protocol is validated.
  • Remove existing server actions and modal based implementation.
  • Implement error dialogs for failure states
  • Implement deletion of already uploaded assets in case of errors

Other changes:

  • Rework structure of active protocol tRPC router to better group by action.

Failure cases to test:

  • Protocol couldn't be read
  • Protocol is invalid
  • Protocol already exists
  • Asset couldn't be read
  • Asset referenced in protocol didn't exist in zip
  • Asset couldn't be uploaded
  • Protocol couldn't be inserted into database

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fresco ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 8:39pm

@jthrilly jthrilly marked this pull request as ready for review November 22, 2023 13:15
@jthrilly jthrilly merged commit 1df3e8c into main Nov 22, 2023
3 checks passed
@jthrilly jthrilly deleted the feature/client-side-protocol-validation branch April 5, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant