Feature/plausible #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses refetch to ensure ui reflects current data. this is causing an issue with the steps routing as it reroutes to step 2 when it revalidates
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
also adds commented out props for when we switch to selfhosted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the necessary changes in Fresco to allow it to connect to Plausible. This is tested in a free trial of the managed version of Plausible. This PR's implementation of
PlausibleProviderhas commented out props that should make this compatible with self hosted once they're added back in.next-plausibleand itsPlausibleProviderto connect the app to PlausibleAppSetupandProtocolImportedinstallationId(which replaced the joint key forAppSettings) each time a goal is triggered so that goals can be managed by installation