Skip to content

Commit

Permalink
switch to running build since it generates types and includes lint an…
Browse files Browse the repository at this point in the history
…d ts-lint
  • Loading branch information
jthrilly committed Oct 11, 2023
1 parent 09446dd commit 74fbf39
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 35 deletions.
36 changes: 3 additions & 33 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Lint and TS Check
name: Build

on:
push:
Expand All @@ -7,7 +7,7 @@ on:
- '*'

jobs:
lint:
build:
runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -35,34 +35,4 @@ jobs:
run: pnpm install --frozen-lockfile

- name: Run ESLint
run: pnpm run lint

ts-lint:
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v3

- uses: pnpm/action-setup@v2
with:
version: 8

- name: Get pnpm store directory
shell: bash
run: |
echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
- uses: actions/cache@v3
name: Setup pnpm cache
with:
path: ${{ env.STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Run TypeScript Lint
run: pnpm run ts-lint
run: pnpm run build
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
"build": "next build",
"dev": "next dev",
"lint": "SKIP_ENV_VALIDATION=true next lint",
"ts-lint": "SKIP_ENV_VALIDATION=true tsc --noEmit",
"ts-lint:watch": "SKIP_ENV_VALIDATION=true tsc --noEmit --incremental --watch",
"ts-lint": "SKIP_ENV_VALIDATION=true tsc --noEmit --incremental --watch",
"start": "next start",
"storybook": "storybook dev -p 6006",
"build-storybook": "storybook build",
Expand Down

0 comments on commit 74fbf39

Please sign in to comment.