Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error Message #312

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Fix Error Message #312

merged 5 commits into from
Oct 23, 2024

Conversation

willtebbutt
Copy link
Member

@willtebbutt willtebbutt commented Oct 23, 2024

The rather cryptic error message shown in #310 is the result of a bug. This PR improves this error message by giving it is own type, and tests that it throws correctly when expected to do so.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/interpreter/s2s_reverse_mode_ad.jl 38.46% 16 Missing ⚠️
Files with missing lines Coverage Δ
src/interpreter/s2s_reverse_mode_ad.jl 92.55% <38.46%> (-0.10%) ⬇️

Copy link
Contributor

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬──────────┬──────────┬─────────────┬─────────┐
│                      Label │ Mooncake │   Zygote │ ReverseDiff │  Enzyme │
│                     String │   String │   String │      String │  String │
├────────────────────────────┼──────────┼──────────┼─────────────┼─────────┤
│                   sum_1000 │     68.6 │      1.0 │        5.41 │ missing │
│                  _sum_1000 │     6.67 │ 335000.0 │        34.6 │ missing │
│               sum_sin_1000 │     2.22 │     1.68 │        10.5 │ missing │
│              _sum_sin_1000 │     2.56 │    237.0 │        12.9 │ missing │
│                   kron_sum │     83.1 │     5.04 │       274.0 │ missing │
│              kron_view_sum │     65.5 │     10.3 │       270.0 │ missing │
│      naive_map_sin_cos_exp │     2.53 │  missing │        7.11 │ missing │
│            map_sin_cos_exp │     2.77 │     1.42 │        6.33 │ missing │
│      broadcast_sin_cos_exp │     2.66 │     2.25 │        1.45 │ missing │
│                 simple_mlp │      7.7 │     4.33 │        16.9 │ missing │
│                     gp_lml │     4.54 │     1.55 │     missing │ missing │
│ turing_broadcast_benchmark │     3.79 │  missing │        22.9 │ missing │
│         large_single_block │     4.03 │   3990.0 │        30.2 │ missing │
└────────────────────────────┴──────────┴──────────┴─────────────┴─────────┘

@willtebbutt willtebbutt merged commit 7b19e95 into main Oct 23, 2024
20 of 21 checks passed
@willtebbutt willtebbutt deleted the wct/fix-error-message branch October 23, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant