-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compas_rhino.uninstall updated for ipy rhino8 #1383
base: main
Are you sure you want to change the base?
Conversation
5961732
to
4406396
Compare
src/compas_rhino/uninstall.py
Outdated
if version == "8.0": | ||
# In Rhino 8 there is no scripts folder | ||
installation_path = compas_rhino._get_default_rhino_ironpython_sitepackages_path(version) | ||
else: | ||
# We install COMPAS packages in the scripts folder | ||
# instead of directly as IPy module. | ||
installation_path = compas_rhino._get_rhino_scripts_path(version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we perhaps do both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the goal of uninstalling is to remove all traces of packages, so perhaps we should try removing them from all possible locations...
@tetov can you add an entry in the CHANGELOG? |
Updated to reflect @tomvanmele's comment above In 642594f we now get:
|
1aff919
to
642594f
Compare
Updated uninstall to match install, like here: cbe33b4
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).I added new functions/classes and made them available on a second-level import, e.g.compas.datastructures.Mesh
.I have added tests that prove my fix is effective or that my feature works.I have added necessary documentation (if appropriate)