Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Similar API changes as for surfaces... #1376

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Similar API changes as for surfaces... #1376

merged 2 commits into from
Jul 4, 2024

Conversation

tomvanmele
Copy link
Member

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 68.57143% with 11 lines in your changes missing coverage. Please review.

Project coverage is 59.90%. Comparing base (8007489) to head (bb3b72d).

Files Patch % Lines
src/compas/geometry/curves/nurbs.py 66.66% 8 Missing ⚠️
src/compas/geometry/curves/curve.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1376      +/-   ##
==========================================
- Coverage   59.94%   59.90%   -0.04%     
==========================================
  Files         206      206              
  Lines       22151    22134      -17     
==========================================
- Hits        13278    13260      -18     
- Misses       8873     8874       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

def __init__(self, name=None):
super(NurbsCurve, self).__init__(name=name)
def __new__(cls, *args, **kwargs):
if cls is Curve:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be NurbsCurve instead of Curve

Copy link
Member

@chenkasirer chenkasirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomvanmele tomvanmele merged commit 7803b29 into main Jul 4, 2024
18 checks passed
@tomvanmele tomvanmele deleted the curve-api branch July 4, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants