Merge pull request #44 from companieshouse/feature/add-delete-error-t…

…ests

Add retry and error delete integration tests

src/itest/java/uk/gov/companieshouse/disqualifiedofficers/delta/steps/CommonSteps.java

@@ -133,6 +133,25 @@ public void theConsumerReceivesDelete() throws Exception {
         countDown();
     }
 
+    @When("the consumer receives an invalid delete payload")
+    public void theConsumerReceivesInvalidDelete() throws Exception {
+        configureWiremock();
+        ChsDelta delta = new ChsDelta("invalid", 1, "1", true);
+        kafkaTemplate.send(mainTopic, delta);
+
+        countDown();
+    }
+
+    @When("^the consumer receives a delete message but the data api returns a (\\d*)$")
+    public void theConsumerReceivesDeleteMessageButDataApiReturns(int responseCode) throws Exception{
+        configureWiremock();
+        stubDeleteDisqualification(responseCode);
+        ChsDelta delta = new ChsDelta(TestData.getDeleteData(), 1, "1", true);
+        kafkaTemplate.send(mainTopic, delta);
+
+        countDown();
+    }
+
     @Then("a DELETE request is sent to the disqualifications api with the encoded Id")
     public void deleteRequestIsSent() {
         verify(1, deleteRequestedFor(urlMatching(

src/itest/resources/features/Delete.feature

@@ -3,4 +3,23 @@ Feature: Delete
   Scenario: send DELETE request to data Api
     Given the application is running
     When the consumer receives a delete payload
-    Then a DELETE request is sent to the disqualifications api with the encoded Id
+    Then a DELETE request is sent to the disqualifications api with the encoded Id
+
+  Scenario: send DELETE with invalid JSON
+    Given the application is running
+    When the consumer receives an invalid delete payload
+    Then the message should be moved to topic disqualified-officers-delta-invalid
+
+  Scenario: send DELETE with 400 from data api
+    Given the application is running
+    When the consumer receives a delete message but the data api returns a 400
+    Then the message should be moved to topic disqualified-officers-delta-invalid
+
+  Scenario Outline: send DELETE with retryable response from data api
+    Given the application is running
+    When the consumer receives a delete message but the data api returns a <code>
+    Then the message should retry 3 times and then error
+    Examples:
+    | code |
+    | 404  |
+    | 503  |