Merge pull request #735 from companieshouse/lp-364-update-limited-par…

…tnership-update-patch LP-367 Limited partnerships - Update PATCH function data parameter
companieshouse · Jan 8, 2025 · 479d845 · 479d845
2 parents 2061270 + c04bda9
commit 479d845
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 15 deletions.
diff --git a/src/services/limited-partnerships/service.ts b/src/services/limited-partnerships/service.ts
@@ -30,11 +30,10 @@ export default class LimitedPartnershipsService {
     public async patchLimitedPartnership (
         transactionId: string,
         submissionId: string,
-        body: { type: string; data: Record<string, any> }
+        body: LimitedPartnership["data"]
     ): Promise<Resource<void> | ApiErrorResponse> {
         const URL = `/transactions/${transactionId}/limited-partnership/partnership/${submissionId}`;
         const response: HttpResponse = await this.client.httpPatch(URL, body);
-
         if (response.error) {
             return {
                 httpStatusCode: response.status,

diff --git a/test/services/limited-partnerships/limited.partnerships.spec.ts b/test/services/limited-partnerships/limited.partnerships.spec.ts
@@ -128,10 +128,7 @@ describe("LimitedPartnershipsService", () => {
                 mockValues.TRANSACTION_ID,
                 mockValues.SUBMISSION_ID,
                 {
-                    type: "email",
-                    data: {
-                        email: "[email protected]"
-                    }
+                    email: "[email protected]"
                 }
             );
 
@@ -140,10 +137,7 @@ describe("LimitedPartnershipsService", () => {
                 mockRequest.calledWith(
                     "/transactions/12345/limited-partnership/partnership/09876",
                     {
-                        type: "email",
-                        data: {
-                            email: "[email protected]"
-                        }
+                        email: "[email protected]"
                     }
                 )
             ).to.be.true;
@@ -163,8 +157,7 @@ describe("LimitedPartnershipsService", () => {
                 mockValues.TRANSACTION_ID,
                 mockValues.SUBMISSION_ID,
                 {
-                    type: "email",
-                    data: {}
+                    email: "testemail.com"
                 }
             ) as ApiErrorResponse;
 
@@ -173,9 +166,7 @@ describe("LimitedPartnershipsService", () => {
                 mockRequest.calledWith(
                     "/transactions/12345/limited-partnership/partnership/09876",
                     {
-                        type: "email",
-                        data: {}
-
+                        email: "testemail.com"
                     }
                 )
             ).to.be.true;