Address bug issue #213
Address bug issue #213
Conversation
|
CI: No security warnings found |
|
|
||
| } | ||
| const selectPremise = req.body.correspondenceAddress; |
There was a problem hiding this comment.
should this const be called as correspondenceAddress instead of premise?
|
|
||
| } | ||
| const selectPremise = req.body.correspondenceAddress; | ||
| CorrespondenceAddressDetailsService.saveCorrespondenceDetailsAddress(req, acspData, selectPremise); |
There was a problem hiding this comment.
Do we not have to create an object of the service class first and then call the function?
| const { firstName, lastName, addresses } = acspData; | ||
|
|
||
| /* const acspData : ACSPData = session?.getExtraData(USER_DATA)!; |
There was a problem hiding this comment.
This commented out code can be removed.
| throw new Error("Method not implemented."); | ||
| } | ||
|
|
||
| static saveCorrespondenceAddressToSession (session: Session, req: Request, ukAddresses: UKAddress[], inputPremise: string): void { |
There was a problem hiding this comment.
no need to create static methods.
|
CI: No security warnings found |
| saveDataInSession(req, USER_DATA, acspData); | ||
| res.redirect(BASE_URL + SOLE_TRADER_CORRESPONDENCE_ADDRESS_CONFIRM); | ||
| const autoLookupSessionservice = new CorrespondenceAddressAutoLookService(); | ||
| autoLookupSessionservice.saveCorrespondenceAddressToSession(acspData, req, ukAddresses, correspondencePremise); |
There was a problem hiding this comment.
saveCorrespondenceAddress is enough no need to add "ToSession" in the name
| saveDataInSession(req, USER_DATA, acspData); | ||
| res.redirect(BASE_URL + SOLE_TRADER_CORRESPONDENCE_ADDRESS_CONFIRM); | ||
| const AddressManualservice = new CorrespondenceAddressManualService(); | ||
| AddressManualservice.saveCorrespondenceManualAddress(req, acspData); |
There was a problem hiding this comment.
variable name needs to follow camel casing
|
CI: No security warnings found |
|
CI: No security warnings found |
2 similar comments
|
CI: No security warnings found |
|
CI: No security warnings found |
| country: getCountryFromKey(ukAddress.country), | ||
| postcode: ukAddress.postcode | ||
| }; | ||
| } |
There was a problem hiding this comment.
you can break out of the loop once the match is found
There was a problem hiding this comment.
There is no difference between address and correspondenceAddress. Only one can be used
|
CI: No security warnings found |
| if (ukAddress.premise === inputPremise) { | ||
| const correspondenceAddress: Address = { | ||
| propertyDetails: ukAddress.premise, | ||
| // premise: ukAddress.premise, |
There was a problem hiding this comment.
you can remove this commented code.
| export class CorrespondenceAddressAutoLookService { | ||
| saveCorrespondenceAddress (acspData :ACSPData, ukAddresses: UKAddress[], inputPremise: string): ACSPData { | ||
|
|
||
| const address = { |
There was a problem hiding this comment.
Do you need this anymore?
|
CI: No security warnings found |
|
CI: No security warnings found |
-fix address bug (save session and carry over)
-added service layers