Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tests fail locally because of the "/work/" absolute path #120

Open
bogdantoader opened this issue May 7, 2022 · 1 comment
Open

Some tests fail locally because of the "/work/" absolute path #120

bogdantoader opened this issue May 7, 2022 · 1 comment
Assignees
@fredericpoitevin

Comments

@bogdantoader
Copy link
Member

The absolute path "/work/" in the config files used by the Jupyter notebooks causes the test_notebook to fail when ran locally.
This should be replaced with a relative path, but to do this, the constructor of tem.TEMSimulator should take the config as a dictionary rather than a path
@fredericpoitevin fredericpoitevin self-assigned this May 7, 2022
@fredericpoitevin
Copy link
Member

Thanks @bogdantoader for looking into this! I'll work on a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredericpoitevin fredericpoitevin

Labels
None yet
Projects
PIMS - Hackathon
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bogdantoader @fredericpoitevin