-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReconstructSPI Workflow Infrastructure #33
base: master
Are you sure you want to change the base?
Conversation
Tried to fix the codecov error but no dice - it should only be present in this commit as there is no actual code present. |
Note that the tests were passing fine in #21 As soon as there is some code that gets tested, the test coverage will go up and a 0% test coverage error from init files won't arise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove dependencies. Also do we want to have a dev branch? To see if the testing/linting runs we have to merge into master. And then as something breaks, master is broken.
@geoffwoollard Not sure what you mean by this, surely if the PR's have tests passing before they merge into master things shouldn't break? |
@geoffwoollard I've added a branch "dev" to the requisite spots. |
Yes yes good point! master won't break unless the failing tests in the PR are merged... |
Files for Github workflow in reconstructSPI. Mostly adapted from ioSPI.