feat: add support for ClusterRole RBAC permissions #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morremeyer
force-pushed
the
feat/cronjob-clusterroles
branch
from
bc34027
to
a5fe7fb
Compare
ekeih
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a ClusterRole for the cronjob chart.
It deprecates the
apiAccess.ruleslist in favor ofapiAccess.roleRulesand also implements auto-detection forapiAccess.roleRulesandapiAccess.clusterRoleRules, removing the need to explicitly set another value.I tested all different variants locally and folded the RBAC test values into
default-values.yamlto reduce the number of testse, since the default did not deploy any RBAC configuration so far.