Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@mitchellwrosen: add int-supply, add park-bench, move unix-compat to abandoned #7183

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

mitchellwrosen
Copy link
Contributor

Checklist:

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)
  • (optional) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script

The script runs virtually the following commands in a clean directory:

  stack unpack $package-$version # `-$version` is optional
  cd $package-$version
  rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs
  stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

@@ -5892,6 +5893,7 @@ packages:
- slist # #5965/closed
- syb-with-class
- type-errors-pretty # #5965/closed
- unix-compat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitchellwrosen : Should unix-compat rather go to "grandfathered deps"? I don't think we can abandon it...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreasabel I'm not sure, this comment above "abandoned" seems to describe the situation accurately, though:

    # If you stop maintaining a package (either just on stackage, or
    # completely), you can move it here. It will be disabled if it
    # starts causing problems.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there anyone else in @haskell-pkg-janitors who would like to maintain this, or is the plan to abandon/deprecate the package?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if there is no one else, I can take the Stackage maintainership for unix-compat.

@alaendle alaendle merged commit b584ffb into commercialhaskell:master Dec 4, 2023
1 check passed
alaendle added a commit that referenced this pull request Dec 4, 2023
@andreasabel
Copy link
Contributor

Thanks, @alaendle !

@andreasabel
Copy link
Contributor

@mitchellwrosen : Please give me the hackage upload rights for unix-compat.

@mitchellwrosen
Copy link
Contributor Author

@andreasabel Sure, what's your Hackage username?

@andreasabel
Copy link
Contributor

It is AndreasAbel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants