Update TAvatarProps.size for backwards compatibility
#3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByronDWall
requested review from
stephsprinkle,
jaikamat,
ddouglasz,
tylermorrisford and
misama-ct
and removed request for
a team
🦋 Changeset detectedLatest commit: fbdd863 The changes in this PR will be included in the next version bump. This PR includes changesets to release 98 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -162,7 +178,7 @@ export default Example; | |||
| */ | |||
| shouldIgnoreRowClick?: boolean; | |||
| } | |||
| ``` | |||
| ```` | |||
There was a problem hiding this comment.
nit we might want to remove this extra tick
There was a problem hiding this comment.
fixed in fbdd863
CarlosCortizasCT
approved these changes
Jan 21, 2025
kark
approved these changes
Jan 21, 2025
…ace with defaultProps in TAvatarProps, update avatar styles to assert that the size prop will always be assigned due to default param assignment
ByronDWall
force-pushed
the
bw/update-avatar-types
branch
from
ca0403a to
fbdd863
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
TAvatarProps.sizeprop optional to match previous api surface with defaultProps inTAvatarProps, updates avatar styles to assert that the size prop will always be assigned due to default param assignment.